Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing #472

Closed
wants to merge 9 commits into from
Closed

Typing #472

wants to merge 9 commits into from

Conversation

Fizzadar
Copy link
Member

@Fizzadar Fizzadar commented Nov 1, 2020

WIP branch to track type checking implementation: #439.

Not aiming to type check everything in this PR, just get the tests passing and then typing can be gradually added over time.

UPDATE on the state of this: major blocker is #564, clearing that should make typing much simpler to implement everywhere!

@Fizzadar Fizzadar self-assigned this Nov 1, 2020
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #472 (ba984d2) into master (27f8fb3) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   92.66%   92.61%   -0.05%     
==========================================
  Files         117      117              
  Lines        6690     6691       +1     
==========================================
- Hits         6199     6197       -2     
- Misses        491      494       +3     
Impacted Files Coverage Δ
pyinfra/__init__.py 100.00% <100.00%> (ø)
pyinfra/operations/files.py 100.00% <100.00%> (ø)
pyinfra/pseudo_modules.py 100.00% <100.00%> (ø)
pyinfra/api/state.py 90.04% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f8fb3...ba984d2. Read the comment docs.

@Fizzadar Fizzadar changed the base branch from current to 1.x March 30, 2022 09:56
@Fizzadar
Copy link
Member Author

Superseeded by #881 🎉

@Fizzadar Fizzadar closed this Oct 24, 2022
@Fizzadar Fizzadar deleted the typing branch October 24, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants